Differential D918

Fixing building benchmark for non-Vc Users
ClosedPublic
Actions

Authored by nbrack on Feb 6 2016, 3:59 PM.

Details

Reviewers
stefanobonicatti
Commits
R37:0eaf32672b88: Fix build for non-vc users
Summary

Commit d38c21be221274faf1cf92f7b4b5a147515d76a0 in the krita 3.0 branch corrected the build of benchmarks under windows. However it also broke the benchmark for non-VC user, because it move most `#include lines inside the #ifdef HAVE_VC conditional, which means that no symbol were available for compiling the benchmark. This patch fixes this, by moving the #includes below the #endif`.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nbrack updated this revision to Diff 2230.Feb 6 2016, 3:59 PM
nbrack retitled this revision from to Fixing building benchmark for non-Vc Users.
nbrack updated this object.
nbrack edited the test plan for this revision. (Show Details)
nbrack added a reviewer: stefanobonicatti.
nbrack set the repository for this revision to R37 Krita.
nbrack added a project: Krita.
nbrack added a subscriber: Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptFeb 6 2016, 3:59 PM
stefanobonicatti accepted this revision.Feb 6 2016, 5:05 PM
stefanobonicatti edited edge metadata.

Shoot, i was quite blind in not seeing that #endif.
Do you have push access? Otherwise i'll just push it for you.
Thanks.

This revision is now accepted and ready to land.Feb 6 2016, 5:05 PM
stefanobonicatti added a comment.Feb 6 2016, 6:33 PM

Hey there, i'm going to make another Windows related fix, i will push your fix very soon.
Thanks again.

Closed by commit R37:0eaf32672b88: Fix build for non-vc users (authored by stefanobonicatti). · Explain WhyFeb 6 2016, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2231

View Options

benchmarks/kis_composition_benchmark.cpp

Loading...