Instead of Item { Loader {} } just make the applet
container the Loader. Also saves some prop bindings
for sizing and centering the BusyIndicator, which
still appears correct.
Some props marked read-only as a bonus.
mart | |
davidedmundson |
Plasma |
Instead of Item { Loader {} } just make the applet
container the Loader. Also saves some prop bindings
for sizing and centering the BusyIndicator, which
still appears correct.
Some props marked read-only as a bonus.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
In general +1.
A comment at the top of Loader making it clear it's not a loader for the applet would help.
containments/panel/contents/ui/main.qml | ||
---|---|---|
294 | In the old code this was the size of the applet Might be a problem for tiny panels |
Will add a comment, the sizing thing isn't a problem because the Loader resizes the BusyIndicator.