| tbaumgart | |
| ostroffjh |
| KMyMoney |
I didn't test remote file download/upload, but all tests are green.
The exist() replacement code is duplicated : it would be better to refactor in a namespace that can be used everywhere, but IMO this can be done later.
Please test further and tell me if i can merge this.
| Lint Skipped |
| Unit Tests Skipped |
Hi Olivier,
why do you download and save the data into a file and then read it again? In my opinion it is easier to simply use the QByteArray returned by StoredTransferJob::data() directly.
Best
Chris
| kmymoney/plugins/qif/import/kimportdlg.cpp | ||
|---|---|---|
| 145 | Q_CONSTEXPR short int detailLevel = 0; // "it's a file or a directory or a symlink, or it doesn't exist" | |
| kmymoney/views/kmymoneyview.cpp | ||
| 1337 | Is this line intended? | |
Where? The code must work for a local file as well and loads /save files. So usong directly the data will imply more changes i think.
Fix Christian's observation in kmymoney/plugins/qif/import/kimportdlg.cpp that I forgot
| kmymoney/plugins/csvexport/csvexporterplugin.cpp | ||
|---|---|---|
| 15 | Can't you use KMyMoneyUtils::fileExists() here as well? What am I missing, if not? | |
I can't because kmymoneyutils is in a separate library and not exposed/exported.
If we want to change this, we need more changes, that can happen in another patch, doesn't it?
Isn't KMyMoneyUtils relatively big dependency? If yes, then I would refrain to use it in plugins at all, as it would add significantly to the size of simple plugin.
I would rather agree. Also, what i've done is rather simple: i might have put overkill checks :)
Anyway: good to go?