Add support for version 3 of data device manager interface
ClosedPublic
Actions

Authored by graesslin on Dec 3 2017, 2:55 PM.

Details

Reviewers

Group Reviewers

Frameworks
Plasma
KWin

Commits

R127:a715a6cd1fe3: Add support for version 3 of data device manager interface

Summary

The main difference compared to version 2 is additional drag and drop
actions. The source and destination can negotiate whether the data
should be copied or moved or the user should be asked for either or.
This seems to be important for GTK, but is not yet implemented in Qt.

The main motivation for adding support is that it is required by SDL to
launch on Wayland.

BUG: 386993

Test Plan

Extended test case, sdl apps now start

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Dec 3 2017, 2:55 PM

Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptDec 3 2017, 2:55 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin requested review of this revision.Dec 3 2017, 2:55 PM

ping

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptDec 10 2017, 4:50 PM

lgtm

src/client/datadevice.cpp
177	`delete nullptr` is just fine
src/client/datadevicemanager.h
74	Should `Ask` perhaps become a bigger number in case stuff gets added in the middle later like `Link` or is that unlikely/incompatible?

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptDec 10 2017, 4:56 PM

graesslin added inline comments.Dec 10 2017, 7:23 PM

src/client/datadevicemanager.h
74	It would be incompatible. The values are the same as the flags from the wayland protocol

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptDec 10 2017, 7:23 PM

ngraham added a subscriber: ngraham.Dec 10 2017, 10:45 PM

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptDec 10 2017, 10:45 PM

davidedmundson accepted this revision.Dec 16 2017, 5:17 PM

This revision is now accepted and ready to land.Dec 16 2017, 5:17 PM

Restricted Application edited projects, added Plasma; removed Plasma on Wayland. · View Herald TranscriptDec 16 2017, 5:17 PM

Closed by commit R127:a715a6cd1fe3: Add support for version 3 of data device manager interface (authored by graesslin). · Explain WhyDec 26 2017, 7:42 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma on Wayland; removed Plasma. · View Herald TranscriptDec 26 2017, 7:42 PM

Revision Contents
Changeset List

		Path
M		autotests/client/test_drag_drop.cpp (29 lines)
M		src/client/datadevice.cpp (5 lines)
M		src/client/datadevicemanager.h (14 lines)
M		src/client/dataoffer.h (45 lines)
M		src/client/dataoffer.cpp (111 lines)
M		src/client/datasource.h (57 lines)
M		src/client/datasource.cpp (75 lines)
M		src/client/registry.cpp (2 lines)
M		src/server/datadevice_interface.cpp (51 lines)
M		src/server/datadevicemanager_interface.h (16 lines)
M		src/server/datadevicemanager_interface.cpp (7 lines)
M		src/server/dataoffer_interface.h (27 lines)
M		src/server/dataoffer_interface.cpp (130 lines)
A	M	src/server/dataoffer_interface_p.h (61 lines)
M		src/server/datasource_interface.h (30 lines)
M		src/server/datasource_interface.cpp (72 lines)
M		src/server/seat_interface.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23347	7cb71d0		Dec 3 2017, 2:55 PM	★	★
Diff 2	24382	9121e68	R127:a715a6cd1fe30acc5dde6d820136e67551fb36f6	Dec 26 2017, 7:41 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d70c0584704e	f2f51f2f20fa	7cb71d002b72	Martin Flöser	Add support for version 3 of data device manager interface (Show More…)	Nov 26 2017, 3:31 PM

Add support for version 3 of data device manager interfaceClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 24382

autotests/client/test_drag_drop.cpp

src/client/datadevice.cpp

src/client/datadevicemanager.h

src/client/dataoffer.h

src/client/dataoffer.cpp

src/client/datasource.h

src/client/datasource.cpp

src/client/registry.cpp

src/server/datadevice_interface.cpp

src/server/datadevicemanager_interface.h

src/server/datadevicemanager_interface.cpp

src/server/dataoffer_interface.h

src/server/dataoffer_interface.cpp

src/server/dataoffer_interface_p.h

src/server/datasource_interface.h

src/server/datasource_interface.cpp

src/server/seat_interface.cpp

Add support for version 3 of data device manager interface
ClosedPublic
Actions

Revision Contents
Changeset List