Differential D9126

[RTL] - align properly the selected text for RTL
ClosedPublic
Actions

Authored by mvourlakos on Dec 3 2017, 1:24 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R242:71f8f16fea15: [RTL] - align properly the selected text for RTL
Summary

--align selected text correctly for
PlasmaComponents2.ComboBox taking into account
RTL.

BUG: 387415

Test Plan

use ComboBoxes in RTL and LTR in order
to check a proper behavior

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mvourlakos created this revision.Dec 3 2017, 1:24 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptDec 3 2017, 1:24 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Dec 3 2017, 1:24 PM
davidedmundson accepted this revision.Dec 3 2017, 11:41 PM
This revision is now accepted and ready to land.Dec 3 2017, 11:41 PM
broulik added a subscriber: broulik.Dec 4 2017, 9:35 AM

I don't understand. Isn't this the default and doesn't it automatically mirror it (effectiveHorizontalAlignment)? (I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place)

mvourlakos added a comment.Dec 4 2017, 10:42 AM

without that line there is the following problem:

if in the combobox list there are also LTR items then when these items are selected they are aligned to the left and
when the RTL items are selected they are aligned to the right.

By adding that line the LTR items in an RTL environment are aligned correctly to the right.

mvourlakos added a comment.Dec 4 2017, 5:06 PM
In D9126#175594, @broulik wrote:

(I'd be fine with this one liner going in but I'm wondering why it would be needed in the first place)

are we ok for landing this?

Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text for RTL (authored by mvourlakos). · Explain WhyDec 5 2017, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23521

View Options

src/declarativeimports/plasmastyle/ComboBoxStyle.qml

Loading...