[Breeze window decoration] Don't repaint title bar if not damaged
ClosedPublic
Actions

Authored by broulik on Dec 2 2017, 5:42 PM.

Details

Reviewers

Group Reviewers

Plasma

Commits

Test Plan

Resized my windows with super large border size, painted properly. Did not repaint the title bar as often as it used to.

Repository

R31 Breeze

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Dec 2 2017, 5:42 PM

Breaks rendering of title bar buttons on hover

This revision is now accepted and ready to land.Dec 2 2017, 6:02 PM

kdecoration/breezedecoration.cpp
479	are you sure contains is correct here? If repaint Region intersects the titleRect it should get repainted?

kdecoration/breezedecoration.cpp
479	Only if `proper = true` is set, the rect would need to be entirely contained inside the other.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kdecoration/breezedecoration.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23297			Dec 2 2017, 5:40 PM	★	★
Diff 2	23298			Dec 2 2017, 5:50 PM	★	★
Diff 3	23316	b54d21e	R31:f0709ccc26c38d940d10c13c38f4811f60066db7	Dec 3 2017, 10:18 AM	★	★