All tests pass.
- Group Reviewers
- R261:fd0c2ec455de: Create d-pointer for MyMoneyObject
Compiles here and tests run successfully.
even better here?
Same here as above (!empty()). Also, I noticed that the Q_ASSERT stuff does not do anything here in my environment. What would I need to do see if it fails?
seems to be the wrong name here
This looks a bit different in other classes. Why don't you need
Same question as with MyMoneyPayee.
I don't know, maybe create MyMoneyObject wit nonempty ID.
It'll be all deleted in near future anyways.
MyMoneyPayeeIdentifierContainer doesn't have d_ptr, so no ambiguity here.
MyMoneyTag inherits only MyMoneyObject, so no abiguity when it comes to d_ptr.
Ah, I forgot to mention, that I saw more of these. Sorry. I scanned real quick and did not see only this one.
Same as above: but this one is all over the place. If you want to replace it, go ahead. If not: it is not mission critical.
Hi! Did you do a performance comparison? I am concerned that this patch can reduce performance significantly because some of the objects are created very often and in huge amounts. Additionally we perform searches with them. Also I am not sure if these very simple objects (often POD) can really benefit from a d-pointer, except ABI stability. The drawback is increased code complexity.
- Performance is the least I care for now. I welcome any standarized test procedure and load case for measuring performance.
As of today KMM isn't optimized neither for speed nor compilation time. My goal is to at least reduce compilation time and number of issues reported here http://ebn.kde.org/krazy/reports/extragear/office/kmymoney/index.html.
- QString in MyMoneyObject isn't POD type
- KMM is already complex in some areas (see reports) and it gives us nothing. Complexity here gives us, besides ABI stability, hopefully reduced compilation time.
If you would look a little bit closer, d-pointer in MyMoneyObject is shared and used in all classes that inherit from it. That classes have more variables in them and IMO that already justifies d-pointer in MyMoneyObject.