Add implementation of kundo2_aware_xgettext() to be shared between Krita, Kexi and Calligra
Needs ReviewPublic

Authored by aspotashev on Dec 1 2017, 11:44 PM.

Details

Reviewers
ltoscano
aacid
Summary

Add implementation of kundo2_aware_xgettext() to be shared between Krita, Kexi and Calligra. Copied from calligra.git/kundo2_aware_xgettext.sh with minor changes in the comments.

Test Plan

extract-messages.sh works correctly with a modified version of krita/Messages.sh.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
aspotashev requested review of this revision.Dec 1 2017, 11:44 PM
aspotashev created this revision.
aacid added a comment.Dec 2 2017, 11:58 AM

I'm not convinced we need to support anything than Qt l10n and ki18n.

Maybe what the krita guys want to do is contribute their impromevements upstream?

kundo2 is a thin wrapper around ki18n, not a third implementation besides Qt l10n and ki18n.

What do you mean by upstream, gettext? ki18n?
These bash functions are too custom to be contributed to gettext, in the same way why you don't contribute the ki18n-specific XGETTEXT_FLAGS from l10n-kf5/scripts/extract-messages.sh into the gettext project.
The xgettext flags from XGETTEXT_FLAGS_KUNDO2 are only relevant to the 3 projects using kundo2:

aacid added a comment.Dec 3 2017, 11:12 AM

kundo2 is a thin wrapper around ki18n, not a third implementation besides Qt l10n and ki18n.

What do you mean by upstream, gettext? ki18n?

I mean ki18n, if this is a must to make undo translations viable, why is it hidden in some "non-standard" library? Maybe i'm misunderstanding how useful those classes are

These bash functions are too custom to be contributed to gettext, in the same way why you don't contribute the ki18n-specific XGETTEXT_FLAGS from l10n-kf5/scripts/extract-messages.sh into the gettext project.

Actually gettext understands [most of] the ki18n flags https://paste.kde.org/pdv4ossdq

The xgettext flags from XGETTEXT_FLAGS_KUNDO2 are only relevant to the 3 projects using kundo2: