[Baloo Runner] Add mime data to matches
ClosedPublic
Actions

Authored by broulik on Feb 4 2016, 9:30 PM.

Details

Reviewers

vhanda

Group Reviewers

Plasma

Commits

Summary

Allows to drag and drop around found files.

BUG: 249621

Test Plan

Successfully dropped a bunch of music files, pictures, and documents from KRunner to my desktop

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik retitled this revision from to [Baloo Runner] Add mime data to matches.

broulik updated this object.

broulik edited the test plan for this revision. (Show Details)

broulik added reviewers: Plasma, vhanda.

broulik set the repository for this revision to R120 Plasma Workspace.

broulik added a project: Plasma.

I'm guessing this is for drag and drop.

Seems fairly straightforward.

runners/baloo/baloosearchrunner.cpp
180 ↗	(On Diff #2208)	I don't think this is required. From the QMimeData documentation http://doc.qt.io/qt-5/qmimedata.html#setUrls - "Since Qt 5.0, setUrls also exports the urls as plain text, if setText was not called before, to make it possible to drop them into any lineedit and text editor."

This revision is now accepted and ready to land.Feb 5 2016, 1:44 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			runners/baloo/baloosearchrunner.h (4 lines)
M			runners/baloo/baloosearchrunner.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2208			Feb 4 2016, 9:27 PM	★	★
Diff 2	2226	efdb5e9	rPLASMAWORKSPACE25dab5d872c6b7f27c2f0932888ed77ebfe13fb1	Feb 6 2016, 10:22 AM	★	★