Add an inverse button to level filter widget
ClosedPublic
Actions

Authored by wuweilin on Nov 29 2017, 2:13 PM.

Details

Reviewers

Group Reviewers

Commits

R37:3a3010ca88ff: Add an invert button to the level filter widget
R37:1e5f68ab5d78: Add an invert button to the level filter widget

Summary

BUG 375842

Add an inverse button to level filter widget such that positions
of the black and the white cursor can be swapped.
Add 'inverted' field to KisGradientSlider. In inverted mode,
gradients are drawn in the reverse order, from white to black.
Fix confusing representation of coordinates of cursor in
KisGradientSlider

Signed-off-by: Wuwei Lin <vincentl13x@gmail.com>

Diff Detail

Repository

R37 Krita

Branch

bug375842

Lint

No Linters Available

Unit

No Unit Test Coverage

wuweilin requested review of this revision.Nov 29 2017, 2:13 PM

wuweilin created this revision.

wuweilin added a reviewer: Krita.Dec 3 2017, 11:39 AM

I've only got a little, very minor coding standards niggle. For the rest, this works fine. I've also tested saving a kra file with an adjustment layer with inverted levels, and that is fine as well.

plugins/filters/levelfilter/kis_level_filter.cpp
220	Our coding standards want {} even around one line statements.

This revision is now accepted and ready to land.Dec 3 2017, 2:51 PM

Fix coding style issue

Do you have push access already, or should we push the patch for you?

In D9052#176048, @rempt wrote:

Do you have push access already, or should we push the patch for you?

No, please help me about that. Thanks.

Closed by commit R37:3a3010ca88ff: Add an invert button to the level filter widget (authored by rempt). · Explain WhyDec 8 2017, 11:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/ui/widgets/kis_gradient_slider.h (3 lines)
M			libs/ui/widgets/kis_gradient_slider.cpp (150 lines)
M			plugins/filters/levelfilter/kis_level_filter.h (4 lines)
M			plugins/filters/levelfilter/kis_level_filter.cpp (34 lines)
M			plugins/filters/levelfilter/wdg_level.ui (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23138	86dfaf0		Nov 29 2017, 2:13 PM	★	★
Diff 2	23481	86dfaf0	Fix coding style issue	Dec 5 2017, 8:09 AM	★	★
Diff 3	23635	5077699	R37:3a3010ca88ff0e2f5dcbccec8cb5e078e824cb2f	Dec 8 2017, 11:03 AM	★	★