Better UI for the "Create a new vault" button
ClosedPublic

Authored by ivan on Nov 29 2017, 8:22 AM.

Details

Summary

The button to create a new vault now:

  • has an icon "list-add"
  • shows in the center of the applet when there are no existing vaults

BUG: 385972

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan created this revision.Nov 29 2017, 8:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 29 2017, 8:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan requested review of this revision.Nov 29 2017, 8:22 AM
ivan retitled this revision from "New vault" action is now a tool button to Better UI for the "Create a new vault" button.Nov 29 2017, 8:24 AM
ngraham edited the summary of this revision. (Show Details)Nov 29 2017, 2:30 PM
ngraham added a comment.EditedNov 29 2017, 4:44 PM

There's a visual glitch. The text escapes the boundaries of the button:

I would still prefer this to always look like a button, like the Bluetooth widget, but I won't block on that.

ngraham requested changes to this revision.Nov 29 2017, 4:44 PM
This revision now requires changes to proceed.Nov 29 2017, 4:44 PM
ivan updated this revision to Diff 23161.Nov 30 2017, 7:04 AM
  • Reverted the 'create a new vault button' to be a proper button
ivan edited the summary of this revision. (Show Details)Nov 30 2017, 7:05 AM
ivan added a comment.Nov 30 2017, 7:07 AM

@ngraham I can not reproduce the text overflow bud you are getting. I'm not setting any size-related things, so the bug is probably in the upstream (libplasma or above)

I've reverted the ToolButton change. I agree that systray applets should be unified - either all use Buttons, or all should use ToolButtons.

mart added a subscriber: mart.Nov 30 2017, 3:44 PM

code change looks fine, and no, shouldn't do that layouting bug, (nor i can reproduce with long text inside plasma buttons)

ngraham accepted this revision.Nov 30 2017, 4:16 PM

OK, if it's just me, then +1. I'll have to look into what's up with my Neon dev VM.

This revision is now accepted and ready to land.Nov 30 2017, 4:16 PM
This revision was automatically updated to reflect the committed changes.