Differential D904

[Baloo Runner] Allow opening parent folder
ClosedPublic
Actions

Authored by broulik on Feb 4 2016, 7:47 PM.

Details

Reviewers
vhanda
mart
Group Reviewers
Plasma
Commits
R871:a18be0a6e61a: [Baloo Runner] Allow opening parent folder
R120:a18be0a6e61a: [Baloo Runner] Allow opening parent folder
Summary

This allows opening the folder a file is located.

BUG: 340302

Test Plan

I'm not sure if I used the actionsForMatch API correctly, Also, looks a tad awful with all those folder icons; perhaps we should use half opacity for the runner actions?

I would have loved to add a screenshot but I have no idea how to do that in Phabricator

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2199.Feb 4 2016, 7:47 PM
broulik retitled this revision from to [Baloo Runner] Allow opening parent folder.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, vhanda.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 4 2016, 7:47 PM
broulik edited the test plan for this revision. (Show Details)Feb 4 2016, 7:48 PM
mart accepted this revision.Mar 2 2016, 1:09 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Mar 2 2016, 1:09 PM
Closed by commit R120:a18be0a6e61a: [Baloo Runner] Allow opening parent folder (authored by broulik). · Explain WhyMar 2 2016, 1:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2518

View Options

runners/baloo/baloosearchrunner.h

Loading...
View Options

runners/baloo/baloosearchrunner.cpp

Loading...