- Don't autostart KRunner, use actions in the desktop file to
define global shortcuts and actions
- install its desktop file in share/kglobalaccel to make shortcuts default
- expand commandline options to permit more control via commandline
Details
Details
- Reviewers
davidedmundson mart - Group Reviewers
Plasma - Maniphest Tasks
- T10958: Faster Startup
- Commits
- R120:cac7af89b7eb: use desktop file actions instead of global shortcuts
works, as expected except
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Needs the things you pointed out in the comment, but otherwise looks good.
Can you confirm you can set shortcuts in systemsettings correctly?
Comment Actions
Overall fine with me.
What hapens to places like Plasma's context menu that show "Run command (Alt+F2)"? What shortcut will they show and do they still work? Same for typing on the desktop.
| krunner/main.cpp | ||
|---|---|---|
| 72 | Use initializer list {QStringLiteral("c"), QStringLiteral("clipboard")} | |
| 78 | Why no i18n() here? Also, QStringLiteral("query") | |
| 117 | This stuffin the lambda is somewhat duplicated, isn't it? | |
Comment Actions
they still work, tough typing on desktop may lose some letters.. i wonder if would make sense to catch them plasmashell-side then launch krunner with the query as parameter...
Comment Actions
delaying the first show seems to fix the focus issue.
a fixed timer of 100ms is of course not a solution but may give some insight in what the problem actually is (a 0 delay timer doesn't work either)
| krunner/update/krunnerglobalshortcuts.cpp | ||
|---|---|---|
| 34 |
File=kglobalshortcutsrc in the .upd. The syntax allows for quite a lot of manipulation.
kconf_update runs, the config updates, kglobalacceld is still running so later syncs undoing your script. Sorry :/ | |
Comment Actions
I have a plan for a kconf_update v2 which would resolve the problem above nicely
Probably means this would be 5.14.
Otherwise you can copy my 4ae36ddddaee91a23dcb0736418295269da14152 in powerdevil
Comment Actions
- Write migration script that uses kglobalaccel at runtime
- Adjust desktop context menu to read the new shortcut
- Remove activation timer as here the window gets focus mostly fine