This path allow to launch a webbrowser as a detached process. If the launch fails, it will display an error message and close the debug session properly (when connection exists of not).
Details
Diff Detail
- Repository
- R68 KDevelop XDebug Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
To clarify my comment above, if what I said is correct, I would suggest to call the function "processFailedToStart"or so, and make it a non-slot.
Yes, anyway I use that name because is consistent with the XDebugJob class (which uses the same mehtod name). Note that this path try to solve:
- The webbrowser launch.
- Display error when something wrong happens.
- Correctly (?) end the debugger even if there is not connection available (side effect of having a connection -> debug state map)
Yes, but the new method doesn't do the same thing as the one in the other class. Thus the consistency is confusing instead of helpful, because the same name suggests the same functionality (which it does not have). If I see a method named "processError" I assume it is connected to the "error" signal of a QProcess or similar, which is the case in XDebugJob but not here. The "if error == QProcess::FailedToStart" is not helpful either, because that suggests it could be different (which it can't be).