Differential D903

Support to Sage backend versions greater than 6.5.
ClosedPublic
Actions

Authored by fernandoteles on Feb 4 2016, 7:34 PM.

Details

Reviewers

filipesaraiva

Group Reviewers

Cantor

Maniphest Tasks

T1029: Update Sage backend to support the most recent version of Sage

Summary

Cantor supports Sage backend. After version 6.5, Sage changed its name to SageMath. So, Cantor supports to newer versions was broken. I changed a string to resolve this issue.

Test Plan

Run Cantor with Sage 6.5, 6.9 and 7.0 versions. It worked normally.

Diff Detail

Repository

R55 Cantor

Lint

Lint Skipped

Unit

Unit Tests Skipped

fernandoteles updated this revision to Diff 2195.Feb 4 2016, 7:34 PM

fernandoteles retitled this revision from to Support to Sage backend versions greater than 6.5..

fernandoteles updated this object.

fernandoteles edited the test plan for this revision. (Show Details)

fernandoteles added a reviewer: filipesaraiva.

fernandoteles set the repository for this revision to R55 Cantor.

fernandoteles added a project: Cantor.

fernandoteles added a task: T1029: Update Sage backend to support the most recent version of Sage.Feb 4 2016, 9:02 PM

This commit is related to bug #348128.

Thanks @fernandoteles, it is correct.

Please, uses in your commit message the special keyword BUG: 348128 to close bug #348128 and FIXED-IN: 16.04.

In addition, put in new lines the sentences CLOSES D903 and DONE T1029. Let's see if Phabricator can to close the Differential review and the Maniphest task automagically. ;)

This revision is now accepted and ready to land.Feb 5 2016, 2:01 PM

filipesaraiva mentioned this in R55:5d185d21431a: After version 6.5, Sage changed its name to SageMath. So, Cantor supports to….Feb 6 2016, 7:52 PM

Hi @fernandoteles, please could you see if there is any "Close"button to this review?
Thanks!

filipesaraiva commandeered this revision.Apr 6 2016, 1:03 AM

filipesaraiva edited reviewers, added: fernandoteles; removed: filipesaraiva.

This revision now requires review to proceed.Apr 6 2016, 1:03 AM

filipesaraiva added a reviewer: Cantor.Apr 6 2016, 1:04 AM

fernandoteles commandeered this revision.Apr 6 2016, 6:22 PM

fernandoteles edited reviewers, added: filipesaraiva; removed: fernandoteles.

filipesaraiva accepted this revision.Apr 6 2016, 6:23 PM

filipesaraiva edited edge metadata.

This revision is now accepted and ready to land.Apr 6 2016, 6:23 PM