Differential D902

[DesktopView] Allow Shift modifier for triggering KRunner
ClosedPublic
Actions

Authored by broulik on Feb 4 2016, 7:17 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:d7c5c99ad05c: [DesktopView] Allow Shift modifier for triggering KRunner
R120:d7c5c99ad05c: [DesktopView] Allow Shift modifier for triggering KRunner
Summary

We were rejecting all key presses that had modifier in it, this included upper-case letters because of Shift being pressed.

Accept keys where *only* the Shift modifier is pressed, too.

BUG: 353959

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2197.Feb 4 2016, 7:17 PM
broulik retitled this revision from to [DesktopView] Allow Shift modifier for triggering KRunner.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 4 2016, 7:17 PM
mart accepted this revision.Feb 4 2016, 7:34 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 4 2016, 7:34 PM
Closed by commit R120:d7c5c99ad05c: [DesktopView] Allow Shift modifier for triggering KRunner (authored by broulik). · Explain WhyFeb 6 2016, 10:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/desktopview.cpp (2 lines)

Diff 2227

View Options

shell/desktopview.cpp

Loading...