Differential D9024

Scrollable Area for Browser Internals
ClosedPublic
Actions

Authored by narvaez on Nov 27 2017, 7:40 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R199:993f7175d89f: Scrollable Area for Browser Internals
Summary

The contents of the "Internal" tab in the "Browser" tab are too long for
a 1366x768 screen which makes the lower buttons inaccessible.

Test Plan

Try to resize the Akonadi Console window to a very small size. Before this patch it would not resize beyond certain
point.

Diff Detail

Repository
R199 Akonadi Console
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
narvaez created this revision.Nov 27 2017, 7:40 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 27 2017, 7:40 PM
narvaez requested review of this revision.Nov 27 2017, 7:40 PM
mlaurent requested changes to this revision.Nov 28 2017, 6:55 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/browserwidget_contentview.ui
362

you remove it ? So we set all buttons
Please readd it

386

same here

This revision now requires changes to proceed.Nov 28 2017, 6:55 AM
narvaez updated this revision to Diff 23093.Nov 28 2017, 2:56 PM
  • Restore the buttons property of KEditListWidget
mlaurent accepted this revision.Nov 29 2017, 6:42 AM

It seems ok.
Thanks

This revision is now accepted and ready to land.Nov 29 2017, 6:42 AM
Closed by commit R199:993f7175d89f: Scrollable Area for Browser Internals (authored by narvaez). · Explain WhyNov 29 2017, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/browserwidget_contentview.ui (385 lines)

Diff 23129

View Options

src/browserwidget_contentview.ui

Loading...