Differential D9023

Refactor MyMoneyFile
ClosedPublic
Actions

Authored by wojnilowicz on Nov 27 2017, 6:05 PM.

Details

Reviewers

tbaumgart

Group Reviewers

KMyMoney

Commits

R261:91666bab0885: Refactor MyMoneyFile

Summary

Fix check for inline methods in public classes
Fix check for methods that return 'const' refs in public classes

Test Plan

All tests pass. Changed name of an account.

Diff Detail

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

wojnilowicz requested review of this revision.Nov 27 2017, 6:05 PM

wojnilowicz created this revision.

Fixed some returns of addresses to temporary objects.

Other than the stuff I have commented, it compiles fine and completes tests.

kmymoney/mymoney/mymoneyfile.h
721	You need to change const MyMoneyAccount& MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const into MyMoneyAccount MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const and change const MyMoneyAccount& existingAccount = file->subAccountByName(parentAccount, name); to const MyMoneyAccount existingAccount = file->subAccountByName(parentAccount, name); in that method (around line 894). Also, there is another signature that needs to be updated. The method const MyMoneyAccount& KBankingPlugin::account(const QString& key, const QString& value) const should be converted to MyMoneyAccount KBankingPlugin::account(const QString& key, const QString& value) const

kmymoney/mymoney/mymoneyfile.h

721

You need to change

const MyMoneyAccount& MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const

into

MyMoneyAccount MyMoneyQifReader::findAccount(const MyMoneyAccount& acc, const MyMoneyAccount& parent) const

and change

const MyMoneyAccount& existingAccount = file->subAccountByName(parentAccount, name);

const MyMoneyAccount existingAccount = file->subAccountByName(parentAccount, name);

in that method (around line 894).

Also, there is another signature that needs to be updated. The method

const MyMoneyAccount& KBankingPlugin::account(const QString& key, const QString& value) const

should be converted to

MyMoneyAccount KBankingPlugin::account(const QString& key, const QString& value) const

This revision now requires changes to proceed.Dec 1 2017, 5:35 PM

Closed by commit R261:91666bab0885: Refactor MyMoneyFile (authored by wojnilowicz). · Explain WhyDec 1 2017, 8:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kmymoney/dialogs/transactionmatcher.cpp (3 lines)
M			kmymoney/kmymoney.h (2 lines)
M			kmymoney/kmymoney.cpp (2 lines)
M			kmymoney/models/accountsmodel.cpp (6 lines)
M			kmymoney/models/equitiesmodel.cpp (16 lines)
M			kmymoney/mymoney/mymoneyfile.h (120 lines)
M			kmymoney/mymoney/mymoneyfile.cpp (173 lines)
M			kmymoney/mymoney/mymoneytransactionfilter.cpp (9 lines)
M			kmymoney/plugins/icalendarexport/schedulestoicalendar.cpp (1 line)
M			kmymoney/plugins/interfaces/kmmstatementinterface.h (2 lines)
M			kmymoney/plugins/interfaces/kmmstatementinterface.cpp (2 lines)
M			kmymoney/plugins/kbanking/mymoneybanking.h (2 lines)
M			kmymoney/plugins/kbanking/mymoneybanking.cpp (2 lines)
M			kmymoney/plugins/ofximport/ofximporterplugin.h (2 lines)
M			kmymoney/plugins/ofximport/ofximporterplugin.cpp (2 lines)
M			kmymoney/plugins/qif/import/mymoneyqifreader.h (2 lines)
M			kmymoney/plugins/qif/import/mymoneyqifreader.cpp (6 lines)
M			kmymoney/plugins/statementinterface.h (2 lines)
M			kmymoney/widgets/transaction.cpp (5 lines)
M			kmymoney/wizards/newaccountwizard/kaccounttypepage.h (2 lines)
M			kmymoney/wizards/newaccountwizard/kaccounttypepage.cpp (2 lines)
M			kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.h (2 lines)
M			kmymoney/wizards/newaccountwizard/kgeneralloaninfopage.cpp (2 lines)
M			kmymoney/wizards/newaccountwizard/knewaccountwizard.h (2 lines)
M			kmymoney/wizards/newaccountwizard/knewaccountwizard.cpp (2 lines)
M			kmymoney/wizards/newloanwizard/additionalfeeswizardpage.cpp (1 line)
M			kmymoney/wizards/newloanwizard/knewloanwizard_p.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	23045			Nov 27 2017, 6:04 PM	★	★
Diff 2	23223			Dec 1 2017, 4:23 PM	★	★
Diff 3	23232	277bce8	R261:91666bab08855bf526e61f86ad16bf901f992876	Dec 1 2017, 7:44 PM	★	★