Differential D9022

Keep tags if overwriting a brush with the new brush dialog
ClosedPublic
Actions

Authored by scottpetrovic on Nov 27 2017, 4:53 PM.

Details

Reviewers
woltherav
Group Reviewers
Krita
Summary

This patch is to fix a bug with keeping tags when overwriting presets

saving a new copy of a brush doesn't keep a tag
bugs.kde.org/show_bug.cgi?id=387180

Brush editor regressions
phabricators.kde.org/T4536

Test Plan

The existing bug could be found doing these steps:

  1. Open the brush editor
  2. Increase the brush size
  3. Press the "Save as New Brush" button at the top
  4. Change the preset name so it is the same as the original (overwriting)
  5. Hit the Save button

Since this situation is overwriting an existing preset, it should keep its tags. This patch should make sure that tags are preserved when overwriting an existing preset.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic requested review of this revision.Nov 27 2017, 4:53 PM
scottpetrovic created this revision.
woltherav accepted this revision.Dec 6 2017, 4:06 PM
woltherav added a project: Krita.
woltherav added a subscriber: woltherav.

Code wise this seems good to me, and it does indeed work.

But... weirdly enough, when rightclicking the new preset doesn't give the option to remove it from the copied tags. I suspect that this might be a different bug alltogether, so I'd still push it.

This revision is now accepted and ready to land.Dec 6 2017, 4:06 PM
scottpetrovic closed this revision.Dec 7 2017, 12:34 AM

Thanks for the review @woltherav . Just pushed it out. Closing

Revision Contents
Changeset List

Diff 23039

View Options

libs/ui/widgets/kis_paintop_presets_popup.cpp

Loading...
View Options

libs/ui/widgets/kis_paintop_presets_save.h

Loading...
View Options

libs/ui/widgets/kis_paintop_presets_save.cpp

Loading...