Fix Qt warnings when rect is invalid, e.g. QRect(0,2111 3840x0)
ClosedPublic

Authored by dfaure on Nov 27 2017, 10:35 AM.

Details

Summary
kwin(28512) QPainter::begin|QPainter::QPainter|KWin::Decoration::Renderer::renderToImage QPainter::begin: Paint device returned engine == 0, type: 3
kwin(28512) QPainter::setRenderHints|QPainter::setRenderHint|KWin::Decoration::Renderer::renderToImage QPainter::setRenderHint: Painter must be active to set rendering hints
kwin(28512) QPainter::setWindow|KWin::Decoration::Renderer::renderToImage|?KWinX11Platform.so?  QPainter::setWindow: Painter not active
kwin(28512) QPainter::setClipRect|KWin::Decoration::Renderer::renderToImage|?KWinX11Platform.so?  QPainter::setClipRect: Painter not active
Test Plan

seems to happen on startup, at least (when restarting kwin)

Diff Detail

Repository
R108 KWin
Branch
fix_qt_warnings
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14163
Build 14181: arc lint + arc unit
dfaure created this revision.Nov 27 2017, 10:35 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 27 2017, 10:35 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
dfaure requested review of this revision.Nov 27 2017, 10:35 AM
dfaure updated this revision to Diff 22995.Nov 27 2017, 10:37 AM

Better check, to actually fix the warnings.

Every subclass (X11Renderer, SceneOpenGLDecorationRenderer, SceneXRenderDecorationRenderer) that calls renderToImage() beforehand checks geo.isNull() but not isValid(), so this should be addressed there imho.

dfaure updated this revision to Diff 62112.Jul 20 2019, 1:21 PM
dfaure retitled this revision from Fix Qt warnings when rect is null to Fix Qt warnings when rect is invalid, e.g. QRect(0,2111 3840x0).
dfaure edited the summary of this revision. (Show Details)
dfaure removed a subscriber: broulik.

Better fix as suggested

Restricted Application removed a subscriber: KWin. · View Herald TranscriptJul 20 2019, 1:21 PM
zzag accepted this revision.Jul 22 2019, 5:41 PM
This revision is now accepted and ready to land.Jul 22 2019, 5:41 PM
dfaure closed this revision.Jul 22 2019, 8:12 PM