diff --git a/src/core/entryinternal.cpp b/src/core/entryinternal.cpp --- a/src/core/entryinternal.cpp +++ b/src/core/entryinternal.cpp @@ -133,7 +133,6 @@ void EntryInternal::setName(const QString &name) { - d.detach(); d->mName = name; } @@ -144,7 +143,6 @@ void EntryInternal::setUniqueId(const QString &id) { - d.detach(); d->mUniqueId = id; } @@ -155,7 +153,6 @@ void EntryInternal::setProviderId(const QString &id) { - d.detach(); d->mProviderId = id; } @@ -166,7 +163,6 @@ void EntryInternal::setCategory(const QString &category) { - d.detach(); d->mCategory = category; } @@ -177,7 +173,6 @@ void EntryInternal::setHomepage(const QUrl &page) { - d.detach(); d->mHomepage = page; } @@ -188,7 +183,6 @@ void EntryInternal::setAuthor(const KNSCore::Author &author) { - d.detach(); d->mAuthor = author; } @@ -199,7 +193,6 @@ void EntryInternal::setLicense(const QString &license) { - d.detach(); d->mLicense = license; } @@ -210,7 +203,6 @@ void EntryInternal::setSummary(const QString &summary) { - d.detach(); d->mSummary = summary; } @@ -221,13 +213,11 @@ void EntryInternal::setShortSummary(const QString &summary) { - d.detach(); d->mShortSummary = summary; } void EntryInternal::setChangelog(const QString &changelog) { - d.detach(); d->mChangelog = changelog; } @@ -243,7 +233,6 @@ void EntryInternal::setVersion(const QString &version) { - d.detach(); d->mVersion = version; } @@ -254,7 +243,6 @@ void EntryInternal::setReleaseDate(const QDate &releasedate) { - d.detach(); d->mReleaseDate = releasedate; } @@ -265,7 +253,6 @@ void EntryInternal::setPayload(const QString &url) { - d.detach(); d->mPayload = url; } @@ -276,7 +263,6 @@ void EntryInternal::setUpdateReleaseDate(const QDate &releasedate) { - d.detach(); d->mUpdateReleaseDate = releasedate; } @@ -287,7 +273,6 @@ void EntryInternal::setUpdateVersion(const QString &version) { - d.detach(); d->mUpdateVersion = version; } @@ -298,7 +283,6 @@ void EntryInternal::setPreviewUrl(const QString &url, PreviewType type) { - d.detach(); d->mPreviewUrl[type] = url; } @@ -309,8 +293,6 @@ void EntryInternal::setPreviewImage(const QImage &image, PreviewType type) { - // Don't detach here since this is how we get the fetched preview images. - //d.detach(); d->mPreviewImage[type] = image; } @@ -321,7 +303,6 @@ void EntryInternal::setRating(int rating) { - d.detach(); d->mRating = rating; } @@ -332,7 +313,6 @@ void EntryInternal::setNumberOfComments (int comments) { - d.detach(); d->mNumberOfComments = comments; } @@ -343,7 +323,6 @@ void EntryInternal::setDownloadCount(int downloads) { - d.detach(); d->mDownloadCount = downloads; } @@ -354,7 +333,6 @@ void EntryInternal::setNumberFans(int fans) { - d.detach(); d->mNumberFans = fans; } @@ -365,7 +343,6 @@ void EntryInternal::setDonationLink(const QString &link) { - d.detach(); d->mDonationLink = link; } @@ -375,7 +352,6 @@ } void EntryInternal::setNumberKnowledgebaseEntries(int num) { - d.detach(); d->mNumberKnowledgebaseEntries = num; } @@ -385,7 +361,6 @@ } void EntryInternal::setKnowledgebaseLink(const QString &link) { - d.detach(); d->mKnowledgebaseLink = link; } @@ -410,7 +385,6 @@ void EntryInternal::setSource(Source source) { - d.detach(); d->mSource = source; } @@ -421,13 +395,11 @@ void EntryInternal::setStatus(KNS3::Entry::Status status) { - d.detach(); d->mStatus = status; } void KNSCore::EntryInternal::setInstalledFiles(const QStringList &files) { - d.detach(); d->mInstalledFiles = files; } @@ -438,7 +410,6 @@ void KNSCore::EntryInternal::setUnInstalledFiles(const QStringList &files) { - d.detach(); d->mUnInstalledFiles = files; } @@ -459,13 +430,11 @@ void KNSCore::EntryInternal::appendDownloadLinkInformation(const KNSCore::EntryInternal::DownloadLinkInformation &info) { - d.detach(); d->mDownloadLinkInformationList.append(info); } void EntryInternal::clearDownloadLinkInformation() { - d.detach(); d->mDownloadLinkInformationList.clear(); } @@ -511,7 +480,6 @@ bool KNSCore::EntryInternal::setEntryXML(QXmlStreamReader& reader) { - d.detach(); if (reader.name() != QLatin1String("stuff")) { qWarning() << "Parsing Entry from invalid XML"; return false; @@ -609,7 +577,6 @@ bool KNSCore::EntryInternal::setEntryXML(const QDomElement &xmldata) { - d.detach(); if (xmldata.tagName() != QLatin1String("stuff")) { qWarning() << "Parsing Entry from invalid XML"; return false;