Patch to have tests and benchmarks build on Windows
ClosedPublic
Actions

Authored by stefanobonicatti on Feb 4 2016, 6:48 PM.

Details

Reviewers

abrahams
rempt

Commits

R37:d38c21be2212: Make tests and benchmarks build on Windows

Summary

As the title says with this patch the tests and benchmarks finally build on Windows, so we can more reliably test Krita functionality on it.

PS: i've noticed now a couple of white space only changes, i'll reupload a better diff soonish.

Test Plan

Test if it compiles on Linux.
Test if it compiles on OSX.

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

stefanobonicatti retitled this revision from to Patch to have tests and benchmarks build on Windows.

stefanobonicatti updated this object.

stefanobonicatti edited the test plan for this revision. (Show Details)

stefanobonicatti set the repository for this revision to R37 Krita.

Cleaned up newline/white space changes.

Builds fine on OSX. I'd just remove the comment-out if (WIN32) around benchmarks.

This revision is now accepted and ready to land.Feb 5 2016, 7:32 AM

Removed the commented-out part.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (6 lines)
M			benchmarks/CMakeLists.txt (2 lines)
M			benchmarks/kis_composition_benchmark.cpp (80 lines)
M			benchmarks/kis_mask_generator_benchmark.cpp (3 lines)
M			libs/image/tiles3/CMakeLists.txt (1 line)
M			libs/psd/CMakeLists.txt (7 lines)
M			libs/ui/tests/CMakeLists.txt (2 lines)
M			plugins/color/lcms2engine/CMakeLists.txt (5 lines)
M			plugins/color/lcms2engine/tests/CMakeLists.txt (2 lines)
M			plugins/extensions/dockers/animation/CMakeLists.txt (2 lines)
M			plugins/extensions/dockers/lut/CMakeLists.txt (2 lines)
M			plugins/extensions/dockers/lut/tests/CMakeLists.txt (4 lines)
M			plugins/extensions/dockers/lut/tests/kis_ocio_display_filter_test.cpp (6 lines)
M			plugins/impex/psd/CMakeLists.txt (6 lines)
M			plugins/impex/psd/tests/CMakeLists.txt (21 lines)
M			plugins/impex/psd/tests/psd_colormode_block_test.cpp (6 lines)
M			plugins/impex/psd/tests/psd_header_test.cpp (2 lines)
M			plugins/impex/psd/tests/psd_utils_test.cpp (2 lines)
M			plugins/tools/tool_transform2/CMakeLists.txt (4 lines)
M			plugins/tools/tool_transform2/tests/CMakeLists.txt (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2194			Feb 4 2016, 6:46 PM	★	★
Diff 2	2202			Feb 4 2016, 8:35 PM	★	★
Diff 3	2223			Feb 5 2016, 6:53 PM	★	★
Diff 4	2224	1f56d27	rKRITAd38c21be221274faf1cf92f7b4b5a147515d76a0	Feb 5 2016, 6:56 PM	★	★