This is copied from KScreenlocker, but will be utilized in Baloo too.
Details
Details
- Reviewers
graesslin krop - Commits
- R240:c30802019895: Add FindSeccomp to find-modules
- Autotests are working
- KScreenlocker and Baloo build with seccomp enabled
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 51–56 | I'm not sure about this. @graesslin is this nessecarry? Most find-modules don't check for the CMake version, and we don't do anything special here. | |
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 51–56 | No idea, that's copy pasted from some other cmake modules. | |
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 51–56 | Well, based on the fact that no other find-module includes such a check, I will remove it. | |
Comment Actions
Thank you, missed this when renaming the docs.
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 13 | Well....I'm for it! ;) | |
Comment Actions
Mostly good. Last question : is the version important ? If yes, please add an additional way to get the version if Seccomp_VERSION is empty. (you can parse seccomp.h to find it, look at the other Find*.cmake modules for examples)
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 4 | nitpick : missing 2 dashes | |
| 52 | Also add the QUIET keyword here | |
| 55 | This doesn't look useful. Looking at my pkgconfig file, the cflags just adds the include dir. If neither baloo or kscreenlocker use it, just remove this line and #85. | |
| find-modules/FindSeccomp.cmake | ||
|---|---|---|
| 22 | 5.44.0 | |