In eventFilter() pass on to base class and only eat events when needed
ClosedPublic

Authored by kossebau on Nov 24 2017, 10:47 PM.

Details

Summary

Clazy pointed out some overly greedy eventFilter() implementations.
No bugs uncovered by this, but feels better to not ignore possible needs of
base classes as well as other instances being interested in events.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Nov 24 2017, 10:47 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 24 2017, 10:47 PM

This is the last left-overs from my clazy run-and-fix collection done earlier this week. I did level2 with some checks masked-out (forgot what actually), also skipped some complicated-looking hits or perhaps false positive.

So anyone invited to do some clazy runs themselves still, there is more to discover, learn and fix :)

kfunk accepted this revision.Nov 25 2017, 12:15 AM
kfunk added a subscriber: kfunk.

Change looks sane to me, but I didn't test it locally.

Did you verify every widget you touched still behaves as it should? :)

This revision is now accepted and ready to land.Nov 25 2017, 12:15 AM
In D8990#171763, @kfunk wrote:

Change looks sane to me, but I didn't test it locally.

Did you verify every widget you touched still behaves as it should? :)

Isn't that what users are for?

:) Well, had done that, and the quick open code had some my-small-real-world testing the last days as well. So average confident.

This revision was automatically updated to reflect the committed changes.