Clazy pointed out some overly greedy eventFilter() implementations.
No bugs uncovered by this, but feels better to not ignore possible needs of
base classes as well as other instances being interested in events.
Details
Details
- Reviewers
kfunk - Group Reviewers
KDevelop - Commits
- R32:1c5686cd1b6f: In eventFilter() pass on to base class and only eat events when needed
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This is the last left-overs from my clazy run-and-fix collection done earlier this week. I did level2 with some checks masked-out (forgot what actually), also skipped some complicated-looking hits or perhaps false positive.
So anyone invited to do some clazy runs themselves still, there is more to discover, learn and fix :)
Comment Actions
Change looks sane to me, but I didn't test it locally.
Did you verify every widget you touched still behaves as it should? :)
Comment Actions
Isn't that what users are for?
:) Well, had done that, and the quick open code had some my-small-real-world testing the last days as well. So average confident.