Differential D8979

ecm_add_test: Use proper path sep on Windows
ClosedPublic
Actions

Authored by kfunk on Nov 23 2017, 11:07 PM.

Details

Reviewers
dfaure
krop
bcooksley
Commits
R240:64915e0291cd: ecm_add_test: Use proper path sep on Windows
Summary

We need to separate paths in environment variables
with a semincolon (;) on Windows.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Nov 23 2017, 11:07 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptNov 23 2017, 11:07 PM
Restricted Application added subscribers: Build System, Frameworks. · View Herald Transcript
kfunk added a reviewer: krop.Nov 23 2017, 11:07 PM
kfunk added a reviewer: bcooksley.
kfunk added a subscriber: Windows.
dfaure accepted this revision.Nov 23 2017, 11:26 PM

Ah, oops, indeed.

This revision is now accepted and ready to land.Nov 23 2017, 11:26 PM
bcooksley accepted this revision.Nov 24 2017, 8:35 AM

Looks fine to me.

Closed by commit R240:64915e0291cd: ecm_add_test: Use proper path sep on Windows (authored by kfunk). · Explain WhyNov 24 2017, 8:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmodules/ECMAddTests.cmake (7 lines)

Diff 22869

View Options

modules/ECMAddTests.cmake

Loading...