| dfaure |
| Frameworks |
Since breadcrumb menu is opened on mouse press, it may receive
the corresponding mouse release event which may unintentionally
activate the random item which happens to be under mouse pointer.
This commit makes the menu ignore the first mouse release event
unless the pointer was moved. It fixes the issue and still allows
'Press mouse button' -> 'Move to an item' -> 'Release the button'
usage scenario.
BUG: 380287
FIXED-IN: 5.44
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I think you should store the mouse position and then check whether the manhattanLength() between new and old is >= QApplication::startDragDisance() to be consistent with regular click and drag drop handling – not everyone is capable of holding a mouse perfectly still.
Would you mind re-basing this on master? I can reproduce the issue and would be happy to test the patch.
| src/filewidgets/kurlnavigatormenu.cpp | ||
|---|---|---|
| 85 ↗ | (On Diff #26872) | Will this still work if the user is using the mouse in left-handed mode? |
| src/filewidgets/kurlnavigatormenu.cpp | ||||
|---|---|---|---|---|
| 85 ↗ | (On Diff #26872) | Quoting Qt documentation [1]:
Should work just fine. | ||
OK cool. The patch works for me! +1. Get a code review from someone else before committing.
Great, thanks a lot!
Get a code review from someone else before committing.
I don't have push access, so no worries. :)
Instead of the bool member, isn't it enough to test the distance again in mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one difference of behaviour in case someone moves the mouse a bit and then back to the original position, in that case the mouseReleaseEvent considers that no move happened (not sure if that's what you want here).
If user moved the mouse considerably, then it's assumed to be intentional, and the subsequent release event shouldn't be ignored even if the final position is the same as the initial one. This way it is consistent with drag'n'drop behavior.
Besides, only the first mouse release event should be ignored, so a flag is needed anyway.