Elide the label text on the statusbar in the middle
ClosedPublic

Authored by ahmadsamir on Nov 21 2017, 6:13 PM.

Details

Summary

BUG: 387189

Currently the label text on the statusbar is elided in on the right, but that means that when the text gets elided the size of the file isn't shown.

The label text on the statusbar shows the file name, the mime type and the size; the name is already shown in the main window and the mimetype can usually be guessed from the icon or from the extension, so it's usually the size that the user wants to see on the statusbar.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Nov 21 2017, 6:13 PM
ngraham edited the summary of this revision. (Show Details)Nov 21 2017, 6:45 PM

Text elided on the right:


Text elided in the middle:

ngraham accepted this revision.Nov 21 2017, 9:40 PM

I like it.

This revision is now accepted and ready to land.Nov 21 2017, 9:40 PM
elvisangelaccio accepted this revision.Nov 21 2017, 10:22 PM
elvisangelaccio added a subscriber: elvisangelaccio.

By the way, this code can probably be simplified by making m_label a KSqueezedTextLabel. Feel like doing a follow up patch? :)

This revision was automatically updated to reflect the committed changes.