Differential D8921

Improve the edit environment dialogue
ClosedPublic
Actions

Authored by ahmadsamir on Nov 20 2017, 6:22 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:5504bf756e4f: Fix 2 issues with Profile->Edit Environment dialog
R319:eaccb7dc612e: Fix 2 issues with Profile->Edit Environment dialog
Summary

This patch addresses a couple of issues with the Edit Environment dialogue.

  • If the user removed all lines, we just save an empty list (previously the changes wouldn't be saved at all)
  • If the user opens the edit env dialog, changes something, clicks OK, then reopens it before clicking OK/Apply in the edit profile dialogue (the parent dialogue) we show the new env vars.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Nov 20 2017, 6:22 PM
Restricted Application added a project: Konsole. · View Herald TranscriptNov 20 2017, 6:22 PM
hindenburg added a subscriber: hindenburg.Nov 21 2017, 2:07 PM

Thanks, it works except when 1) remove all entries; 2) hit OK; 3) reopen Edit button -> previous lines show up

Can you look into that?

ahmadsamir updated this revision to Diff 22695.EditedNov 21 2017, 3:50 PM

Use _tempProfile->isPropertySet() to check if the environment property changed. This is more sane (than just checking if it's empty, because the environment could be empty if the user removed all lines from the edit env dialogue).

Thanks.

hindenburg accepted this revision.Nov 22 2017, 1:23 PM

look good now - thanks - do you need me to commit it?

This revision is now accepted and ready to land.Nov 22 2017, 1:23 PM
ahmadsamir added a comment.Nov 22 2017, 2:51 PM
In D8921#170640, @hindenburg wrote:

look good now - thanks - do you need me to commit it?

Yes, please. And thanks.

Closed by commit R319:eaccb7dc612e: Fix 2 issues with Profile->Edit Environment dialog (authored by hindenburg). · Explain WhyNov 22 2017, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/EditProfileDialog.cpp (25 lines)

Diff 22747

View Options

src/EditProfileDialog.cpp

Loading...