compute itemrepository version from version plus KDEVELOP_VERSION
ClosedPublic

Authored by brauch on Nov 20 2017, 1:27 PM.

Details

Reviewers
kfunk
mwolff
flherne
Group Reviewers
KDevelop
Summary

This ensures that for each release, we clear the item repository.
In the past, we had various issues related to old caches -- this change
should avold that, since we no longer need to remember to bump the
ITEMREPOSITORY_VERSION variable on each release.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
brauch created this revision.Nov 20 2017, 1:27 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 20 2017, 1:27 PM
kfunk requested changes to this revision.Nov 20 2017, 1:35 PM

LGTM in general.

kdevplatform/config-kdevplatform.h.cmake
6

Maybe rename the CMake var KDEV_ITEMREPOSITORY_VERSION to something like KDEV_ITEMREPOSITORY_INCREMENT to not overlap with the C++ define name and meaning?

Also reset KDEV_ITEMREPOSITORY_INCREMENT to 0.

kdevplatform/serialization/itemrepositoryregistry.cpp
77

Could probably print the staticItemRepositoryVersion(), too.

This revision now requires changes to proceed.Nov 20 2017, 1:35 PM
brauch updated this revision to Diff 22654.Nov 20 2017, 1:53 PM

Do we want this in 5.2?

kfunk accepted this revision.Nov 20 2017, 1:58 PM

I don't mind having this in 5.2, too.

This revision is now accepted and ready to land.Nov 20 2017, 1:58 PM
brauch closed this revision.Nov 20 2017, 2:55 PM

Sorry, forgot to mention the review in the commit message ...

Submitted with 53ec893e8271d to 5.2.