Differential D8910

Add Plasma Mobile session
ClosedPublic
Actions

Authored by bshah on Nov 20 2017, 5:22 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R20:3a73eae701cf: Add Plasma Mobile session
Summary

And also, autoload Plasma Mobile shell if session is plasma-mobile

Test Plan

loaded Plasma Mobile session from the sddm

Diff Detail

Repository
R20 Plasma Phone Components
Branch
add-session
Lint
No Linters Available
Unit
No Unit Test Coverage
bshah created this revision.Nov 20 2017, 5:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2017, 5:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 20 2017, 9:50 AM
This revision is now accepted and ready to land.Nov 20 2017, 9:50 AM
davidedmundson added a subscriber: davidedmundson.Nov 20 2017, 9:59 AM
davidedmundson added inline comments.
shell/contents/loader.qml
28

Not remotely blocking this commit, but does this actually work?

In SDDM, (possibly not correctly?) DESKTOP_SESSION (which is what this property is) is a full path.

Closed by commit R20:3a73eae701cf: Add Plasma Mobile session (authored by bshah). · Explain WhyNov 23 2017, 9:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
AMplasma-mobile.desktop.cmake (7 lines)
Mshell/contents/loader.qml (2 lines)

Diff 22623

View Options

CMakeLists.txt

Loading...
View Options

plasma-mobile.desktop.cmake

Loading...
View Options

shell/contents/loader.qml

Loading...