Differential D8900

Simplify code now that we use the new-style connect
ClosedPublic
Actions

Authored by mwolff on Nov 19 2017, 5:26 PM.

Details

Reviewers
brauch
Commits
R32:3923652b742e: Simplify code now that we use the new-style connect
Summary

This cannot possibly fail anymore

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Nov 19 2017, 5:26 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 19 2017, 5:26 PM
brauch accepted this revision.Nov 19 2017, 5:36 PM
brauch added a subscriber: brauch.

Technically it can fail, I think e.g. if ICore::self()->projectController() is null, but that doesn't happen of course. LGTM

This revision is now accepted and ready to land.Nov 19 2017, 5:36 PM
Closed by commit R32:3923652b742e: Simplify code now that we use the new-style connect (authored by mwolff). · Explain WhyNov 19 2017, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22611

View Options

kdevplatform/language/backgroundparser/backgroundparser.cpp

Loading...