Differential D8896

Add recently added file to .qrc
ClosedPublic
Actions

Authored by janmulder on Nov 19 2017, 3:28 PM.

Details

Reviewers
mart
davidedmundson
Commits
R169:09da1cca814e: Add recently added file to .qrc
Summary

Commit f8ee631aac787b6 added a file but adding it to the .qrc file was forgotten. Breaking Subsurface mobile.

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
janmulder created this revision.Nov 19 2017, 3:28 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 19 2017, 3:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 19 2017, 3:35 PM
This revision is now accepted and ready to land.Nov 19 2017, 3:35 PM
janmulder added a comment.Jan 2 2018, 10:46 AM

Ok, accepted within 7 minutes after creation, but not merged since then (19 november). Do I need to do something? Maybe I just do not understand the development model, merge rights etc?

Closed by commit R169:09da1cca814e: Add recently added file to .qrc (authored by janmulder, committed by davidedmundson). · Explain WhyJan 2 2018, 10:48 AM
This revision was automatically updated to reflect the committed changes.
davidedmundson added a comment.Jan 2 2018, 10:50 AM

We have a somewhat silly process. It was waiting on some dev to pay attention.

If it happens again, just prod the review like you just did there.

janmulder added a comment.Jan 2 2018, 11:41 AM

Ah stupid. It appears that @mart pushed the same fix as part of commit 63a7f75a79c1685268. So this one can be reverted. Sorry. Well, that happens when stuff is sitting around for 6 weeks.

Revision Contents
Changeset List

PathPackages
Mkirigami.qrc (1 line)

Diff 24571

View Options

kirigami.qrc

Loading...