KApidox - CSS
ClosedPublic

Authored by ochurlaud on Jan 30 2016, 7:55 PM.

Details

Summary

I updated the CSS to have it more modern (flat design).

It seems there is a pb on kapidox in src/kapidox/data/templates/fwinfo.html
I had to comment this command: {% if fwinfo.maintainers|count != 0 %}s{% endif %}

You can compare with the current version on http://api.kde.org/frameworks-api/frameworks5-apidocs/

Here are some screenshots:

Index page:

When you pick a class:

Prototypes in a class:

Code overview (only changed the height of line: it's more comfortable to read I think):

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
ochurlaud updated this revision to Diff 2155.Jan 30 2016, 7:55 PM
ochurlaud retitled this revision from to KApidox - CSS.
ochurlaud updated this object.
ochurlaud edited the test plan for this revision. (Show Details)
ochurlaud added a reviewer: ltoscano.
ochurlaud updated this object.Jan 30 2016, 7:58 PM
ochurlaud updated this object.
kfunk added a subscriber: kfunk.Feb 7 2016, 2:38 PM

Screenshot for before/after would be cool

ochurlaud updated this object.Feb 7 2016, 2:50 PM

Btw, if I ship it, it will be only the css files...

The html one is just to show that there seems to be a problem but i don't know on your side...

alexmerry edited edge metadata.Feb 7 2016, 3:36 PM

I'm sure this is said on a regular basis, but at some point we should look at unifying the styling of the KDE websites. In the meantime, this change certainly isn't making them any less unified, and possibly even brings the apidocs slightly closer to the others stylistically.

Could you file a bug for the Maintainers thing, rather than putting it here? If you could describe the problem it causes (eg: paste the error message) on that, it would be useful.

If you upload a diff without that part of the change, I'll happily accept that, unless anyone wants to jump in with discussion about the details of the style change.

I'll open a bug during the week then.

I wait that you tell me to push the style to the repo. I definitely can do the same for lxr and other websites like this.

Else I can try to do something following the planetkde.org website, but I'm not sure it's a good idea: would it fit?

Let me know.

Last thing: I also can put the same background as the wikis / bugzilla.

So it's more unified (just tried: it renders good)

apol added a subscriber: apol.Feb 8 2016, 11:51 AM

Maybe it would make sense to get in touch with the VDG, so they can give their input?

Very interesting step forward! :D

alake added a subscriber: alake.Feb 8 2016, 2:26 PM

This is a very nice improvement. +1 from me.

I'm sure this is said on a regular basis, but at some point we should look at unifying the styling of the KDE websites. In the meantime, this change certainly isn't making them any less unified, and possibly even brings the apidocs slightly closer to the others stylistically.

Currently I'm working on unifying the look of our sites; it's not a small task though as our sites use different systems, and we'll need to individually address content on a per-site basis. This is a good starting point and gets my thumbs up. In the future we will need to make additional revisions, but until I have some more exacting specifications I think anything dragging our websites out of the early 2000's is a good thing, and this puts us in a better position for when things are ready later on.

alexmerry accepted this revision.Feb 8 2016, 6:04 PM
alexmerry edited edge metadata.

On the assumption that the fwinfo.html change won't go in (it's not the correct fix for whatever problem you are seeing there).

This revision is now accepted and ready to land.Feb 8 2016, 6:04 PM