Fix message extraction in kdepim-runtime/resources/ews/wizard/
ClosedPublic

Authored by lueck on Nov 18 2017, 12:19 PM.

Details

Summary

scripty reports the error:
./resources/ews/wizard
/usr/bin/xgettext: error while opening "/home/scripty/prod/git-unstable-kf5/pim_kdepim-runtime/po/accountwizard_ews.pot" for reading: No such file or directory
Bash exit code: 1
see https://logs.l10n.kde.org/171118.trunk_l10n-kf5
why does the file ewswizard.es have the extension "es"?

Test Plan

template accountwizard_ews.pot is succesfully generated with l10n-kf5//scripts/extract-messages.sh

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lueck created this revision.Nov 18 2017, 12:19 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 18 2017, 12:19 PM
ltoscano requested changes to this revision.Nov 18 2017, 1:10 PM
ltoscano added a subscriber: ltoscano.

I think that it should follow the same pattern of the other resource/<foo>/wizard, or they should be all changed.
I would say: add a simply touch of the file before the last line ($XGETTEXT -kqsTr *.es -j -o $podir/accountwizard_ews.pot) which will be useless (but not harmful) when the ui file will contain some messages.
``

This revision now requires changes to proceed.Nov 18 2017, 1:10 PM
lueck updated this revision to Diff 22577.Nov 18 2017, 5:41 PM

follow the pattern of the other resource/<foo>/wizard/Messages.sh
add touch to generate the pot file if it does not exist

ltoscano accepted this revision.Nov 18 2017, 7:57 PM

Thanks! I think that it can go in also into Applications/17.12, as it enables the translation of an existing string.

This revision is now accepted and ready to land.Nov 18 2017, 7:57 PM
This revision was automatically updated to reflect the committed changes.