- Implements proper keyboard navigation (up/down) as well as space to goggle check box
- Makes list sortable by name, comment, and "checked" (so you easily get an overview of types you enabled)
- Add mime type "comment" which is more user-friendly
Details
Details
- Reviewers
hein - Group Reviewers
Plasma VDG - Commits
- R119:7e4f16e8ddfa: [Folder View Filter Config] Use TableView for mime types
- The checkbox becomes hardly visible on a selected row. In QWidgets Breeze has a hack to paint in white in this case but it cannot be done int QQC :/
- Tested keyboard up and down as well as space to toggle
- Sorting and filtering (the filter still only searches the name, not the comment) doesn't seem to confuse the table view or model
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I like it, but should the default sort column be the name so that there's no awkward arrow in the header element for the checkboxes?
I feel like QWidget views or rather QStandardItemDelegate avoid this by embedding the checkbox into the column for Qt::DisplayRole or something ... maybe I misremember though.
Comment Actions
The sorter for checkboxes makes no sense. It is not necessary unless you feel the need to sort by ckecboxes checked or cleared. I imagine it would make more sense when there are hundreds of options. But you also have a sorting field. So no need.
Comment Actions
The default sorting is by name. I was just demonstrating in the screenshot that you could also sort by checked in order to quickly find the checked ones, sorry. There are hundreds of options.
Comment Actions
If the default sorting isn't on the checkbox, then I'm OK with and accept the original ver (not-so-fond of the variant).