Differential D8845

Create tooltipManager on demand
AbandonedPublic
Actions

Authored by broulik on Nov 16 2017, 2:18 PM.

Details

Reviewers
mart
Summary

It takes a couple of milliseconds to be created and isn't vital for System Settings startup.

Test Plan

Tooltips still work

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 16 2017, 2:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 16 2017, 2:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin added a subscriber: graesslin.Nov 16 2017, 4:40 PM
graesslin added inline comments.
sidebar/SidebarMode.cpp
236

toolTipManager = nullptr;

broulik added a comment.Nov 16 2017, 4:43 PM

Look in the constructor, kept it consistent

davidedmundson added a subscriber: davidedmundson.Nov 16 2017, 4:43 PM

I think you've identified something, (well, 0.2% on my PC) , which is good, but I think we should delve deeper into the issue.

KTooltipManager isn't slow, it's the platform window being created in KTooltipWidget constructor that is.
We can just move that code there.

graesslin added a comment.Nov 16 2017, 4:46 PM
In D8845#168632, @broulik wrote:

Look in the constructor, kept it consistent

ah I just made this as a proposal as you had to change unrelated lines.

broulik abandoned this revision.Nov 17 2017, 1:06 PM

D8851 gives virtually the same benefit without having to adjust the applications themselves

Revision Contents
Changeset List

PathPackages
Msidebar/SidebarMode.cpp (12 lines)

Diff 22460

View Options

sidebar/SidebarMode.cpp

Loading...