fix "none" being set as default compiler on windows
ClosedPublic

Authored by geetamc on Nov 13 2017, 11:01 PM.

Details

Summary

and as a result, fix standard msvc include directories not being provided to the language plugin.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
geetamc created this revision.Nov 13 2017, 11:01 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 13 2017, 11:01 PM
mwolff requested changes to this revision.Nov 14 2017, 9:46 AM
mwolff added a subscriber: mwolff.

idea lgtm in general, but please cleanup the implementation

plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
180

use http://doc.qt.io/qt-5/qdir.html#listSeparator

i.e.:

const auto path = QFile::decodeName(rt->getenv("PATH"))
                      .split(QDir::listSeparator());
This revision now requires changes to proceed.Nov 14 2017, 9:46 AM
geetamc updated this revision to Diff 22325.Nov 14 2017, 11:14 AM
  • remove unnecessary ifdef block
mwolff accepted this revision.Nov 15 2017, 10:27 AM

lgtm, will push to 5.2

This revision is now accepted and ready to land.Nov 15 2017, 10:27 AM
This revision was automatically updated to reflect the committed changes.