Install related ref instead attempting to upgrade it
ClosedPublic

Authored by jgrulich on Nov 13 2017, 10:10 AM.

Details

Summary

When upgrading an app, we attempt to also upgrade related refs, but we
fail if some of the listed refs is not installed. We should check whether
we are trying to upgrade installed ref and if not, then just install it.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Nov 13 2017, 10:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 13 2017, 10:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich updated this revision to Diff 22256.Nov 13 2017, 10:18 AM

Print error when we fail to find out whether related ref is installed

apol accepted this revision.Nov 13 2017, 11:54 AM

Thanks! Please submit to 5.11 if it doesn't bump the dependency.

This revision is now accepted and ready to land.Nov 13 2017, 11:54 AM
apol added inline comments.Nov 13 2017, 11:55 AM
libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp
76

Please define and declare at the same line, no need to do it in 2 separate consecutive steps.

In D8784#167078, @apol wrote:

Thanks! Please submit to 5.11 if it doesn't bump the dependency.

It doesn't, I'm just not sure how to land this into Plasma/5.11 branch as I created local branch based on master and when running "arc land --onto Plasma/5.11" it attempts to land all changes from master.

apol added a comment.Nov 13 2017, 12:52 PM

Just cherry-pick the commit into the right branch and git push it.

This revision was automatically updated to reflect the committed changes.