Differential D8779

Avoid hypothetical crash if output->init fails
ClosedPublic
Actions

Authored by davidedmundson on Nov 12 2017, 10:40 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R108:6325749f2117: Avoid hypothetical crash if output->init fails
Summary

con->setOutput and crtc->setOutput is called in Output::~Output so this
is doing it twice redundantly.

More importantly Output::~Output calls crtc->blank(), which means we
need a valid CRTC object there.

Test Plan

Compiles

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: KWin. · View Herald TranscriptNov 12 2017, 10:40 PM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
graesslin requested changes to this revision.Nov 13 2017, 4:17 PM
This revision now requires changes to proceed.Nov 13 2017, 4:17 PM
bshah added a subscriber: bshah.Nov 13 2017, 4:33 PM

@graesslin, you requested changes here but what change? There is no comment

graesslin accepted this revision.Nov 13 2017, 4:35 PM

misclicked, wanted to accept it.

This revision is now accepted and ready to land.Nov 13 2017, 4:35 PM
Closed by commit R108:6325749f2117: Avoid hypothetical crash if output->init fails (authored by davidedmundson). · Explain WhyNov 15 2017, 4:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22399

View Options

plugins/platforms/drm/drm_backend.cpp

Loading...