Show Configure Toolbars dialog as modal

Authored by elvisangelaccio on Nov 12 2017, 11:10 AM.


Group Reviewers

The "Configure Toolbars" dialog was made non-modal a long time ago [1]
in order to allow drag-and-drop of toolbar actions while the dialog is
open. This was a bad idea because:

  1. It is possible to open the Configure Toolbars dialog and then any other modal dialog (e.g. Configure Shortcuts), making the toolbar dialog unusable.
  2. After a drag-n-drop of actions in the toolbar, the order of actions in the "Current actions" column of the toolbar dialog is not updated.

Thanks to D8773 we can show the dialog as modal and fix both issues.

If some application really wants the dialog as non-modal, it can do so
by reimplementing the KXmlGuiWindow::configureToolbars() slot.

Depends on D8773


Diff Detail

R263 KXmlGui
No Linters Available
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2017, 11:10 AM
elvisangelaccio edited the summary of this revision. (Show Details)Nov 12 2017, 11:11 AM
elvisangelaccio edited the summary of this revision. (Show Details)
elvisangelaccio edited the summary of this revision. (Show Details)
dfaure accepted this revision.Nov 12 2017, 6:20 PM
This revision is now accepted and ready to land.Nov 12 2017, 6:20 PM
ngraham added a subscriber: ngraham.Dec 5 2019, 9:00 PM

Can this land?

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptDec 5 2019, 9:00 PM

The description says this depends on D8773 which isn't approved.

Oops, sorry! I added comments to D8773.