Resolve the input method issue by always force focus in search field.
ClosedPublic

Authored by xuetianweng on Nov 12 2017, 10:26 AM.

Details

Summary

ActivityManager.qml doesn't have input method issue because the initial
focus is inside the text field. So here we try to apply the same logic.
Always force focus into the text field first, and handle the rest of key
event accordingly. So we don't need to use event.text to append or do
anything special, because event.text is not a input method compatible
way to handle input.

Test Plan

Manually test arrow key navigation. Also test input method typing is enabled
when menu is opened.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
xuetianweng created this revision.Nov 12 2017, 10:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 12 2017, 10:26 AM

revert the reordering of code in unrelated part

ihipop added a subscriber: ihipop.Nov 12 2017, 1:06 PM
hein accepted this revision.Nov 14 2017, 5:13 AM

Nice.

I think we have the same problem in Kicker and Application Dashboard, which also use append trickery.

This revision is now accepted and ready to land.Nov 14 2017, 5:13 AM
This revision was automatically updated to reflect the committed changes.