Fix translation of toolbar name when it has i18n context
ClosedPublic

Authored by aspotashev on Nov 12 2017, 2:32 AM.

Details

Summary

The Configure Toolbars dialog did not take into account the "context" attribute of toolbar text which should be used as i18n context string.

KDE Partition Manager was affected:

<ToolBar name="editToolBar">
  <text context="@title:menu turn on and off edit toolbar">Edit Toolbar</text>
[...]
Test Plan

Run partitionmanager and check translated toolbar names in: 1. Configure Toolbars dialog; 2. In the menu under "Tools -> Toolbars Shown".

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Nov 12 2017, 2:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2017, 2:32 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol accepted this revision.Nov 12 2017, 6:32 PM
This revision is now accepted and ready to land.Nov 12 2017, 6:32 PM
dfaure accepted this revision.Nov 12 2017, 6:39 PM
dfaure added inline comments.
src/ktoolbarhelper.cpp
33

const QString &key

aspotashev updated this revision to Diff 22243.Nov 12 2017, 9:30 PM

const QString &key

aspotashev marked an inline comment as done.Nov 12 2017, 9:31 PM
This revision was automatically updated to reflect the committed changes.