Differential D8761

ArkViewer: close on Escape
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 11 2017, 3:59 PM.

Details

Reviewers
rthomsen
broulik
Commits
R36:ae758226b8b6: ArkViewer: close on Escape
Summary

BUG: 386729
FIXED-IN: 17.11.80

Test Plan

Open preview for a text file, then check whether Esc closes the window.
If some operation is happening in the kate part (e.g. text selected, or search bar open),
make sure Esc aborts the operation rather than closing the window.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Ark. · View Herald TranscriptNov 11 2017, 3:59 PM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript
broulik accepted this revision.Nov 14 2017, 1:00 PM

Thanks!

This revision is now accepted and ready to land.Nov 14 2017, 1:00 PM
Closed by commit R36:ae758226b8b6: ArkViewer: close on Escape (authored by elvisangelaccio). · Explain WhyNov 14 2017, 10:46 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:ae758226b8b6: ArkViewer: close on Escape.

Revision Contents
Changeset List

PathPackages
Mpart/arkviewer.cpp (1 line)

Diff 22373

View Options

part/arkviewer.cpp

Loading...