Implement SH_Widget_Animation_Duration style hint
ClosedPublic

Authored by elvisangelaccio on Nov 11 2017, 2:57 PM.

Details

Summary

Qt 5.10 deprecates the SH_Widget_Animate style hint in favor of a new
SH_Widget_Animation_Duration hint (see [1]).

If we are building against Qt 5.10 or newer, implement the new hint.

[1]: http://code.qt.io/cgit/qt/qtbase.git/commit/?id=04eba7b538072e2811f074bf66fd41f27c90b35c

Test Plan

qDebug() << style()->styleHint(QStyle::SH_Widget_Animation_Duration) from some QWidget app.

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2017, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
  • Don't use QT_VERSION_CHECK since it's not used anywhere in breeze
apol accepted this revision.Nov 12 2017, 7:37 PM
apol added a subscriber: apol.
apol added inline comments.
kstyle/breezestyle.cpp
657

Move the TODO by SH_Widget_Animate?

This revision is now accepted and ready to land.Nov 12 2017, 7:37 PM
hpereiradacosta accepted this revision.Nov 12 2017, 8:32 PM

Thanks for the patch !

This revision was automatically updated to reflect the committed changes.
elvisangelaccio marked an inline comment as done.Nov 12 2017, 8:40 PM