BUG: 359381
Details
Details
- Reviewers
rkflx broulik - Group Reviewers
KDE Applications
Tested in KDE Neon. Space bar now pauses and resumes the slideshow. Arrow keys continue to work to manually move to the next and previous images
Diff Detail
Diff Detail
- Repository
- R260 Gwenview
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Adding a shortcut: sure.
Adding Space: not a fan (i.e. that's my primary method of navigation and I want to even add ⇧+Space eventually).
I also noticed this bug, BTW, it's still on my list of things to think about. Note there is kind of a conceptual conflict with the video player too, we have:
- Pause Slideshow
- Pause Video
- Next Image
- Forward in Video
- + the other directions…
Ideally we would have a better understanding of want we want regarding this list before changing anything. Maybe different shortcuts for the different modes? But this would be confusing, too…
Edit: Would be worth checking how similar apps are behaving (see https://en.wikipedia.org/wiki/Comparison_of_image_viewers).
Comment Actions
I think it makes the most sense to use the space bar for play/pause rather than navigation. It is virtually universal wherever there is something that can be played or paused. And "space bar for play/pause" is probably one of the most common keyboard shortcuts that your aver computer user knows, after the ones for copy, paste, and print. Space for navigation does not make sense to me when everywhere else in Gwenview the arrow keys are used for navigation.
As for the video issue you describe, we already have another bug tracking that: https://bugs.kde.org/show_bug.cgi?id=312531
Comment Actions
…for navigating in Firefox, holding a presentation in Okular (try finding those tiny arrow keys if you are nervous, Space is much easier – applies also if you are presenting images), next mail in KMail and much more…
Space for navigation does not make sense to me when everywhere else in Gwenview the arrow keys are used for navigation.
It does make sense. Arrow keys stop if you are at the end of the line in Browse mode, Space continues past that.
Comment Actions
Hmm, well if the space bar is a common shortcut to move to the next slide in other slide-based presentations, then we should follow their lead and use whatever the most common shortcut is for pausing and resuming. As you can probably tell, I'm not a heavy user of this genre of software. Any ideas for what a good shortcut might be?
Comment Actions
Note: I agree that Space is universal in video players. It makes sense, because from a usability standpoint it is easy to reach. The primary use case should be reserved for this key. For Gwenview, this is:
- In normal mode: navigation.
- For active slideshows: would make sense for pausing and for navigation.
We could go with P, but this also feels a bit awkward. In such cases I prefer to look at how other are doing it to get some inspiration. I can try to do some research in the next weeks, but it's not my top priority right now and maybe you beat me to it.
Comment Actions
Looks like this is no longer needed now that D10972 has landed and that's the approach we plan to use (at least for people using keyboards that have media control keys, I suppose).
Comment Actions
We still need to figure out shortcut handling wrt. pausing videos vs. the slideshow and also add a shortcut for non-multimedia keyboards, but I guess that's for another time and place…