Differential D8744

Use Qt.callLater instead of creating a Timer
ClosedPublic
Actions

Authored by broulik on Nov 10 2017, 2:17 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:e8c4c3953d4e: Use Qt.callLater instead of creating a Timer
Test Plan

This is new in Qt 5.8.
The kicker dialogs are properly destroyed.
I didn't actually see the one in FolderView being called.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 10 2017, 2:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 10 2017, 2:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Nov 12 2017, 8:04 AM
This revision is now accepted and ready to land.Nov 12 2017, 8:04 AM
Closed by commit R119:e8c4c3953d4e: Use Qt.callLater instead of creating a Timer (authored by broulik). · Explain WhyNov 15 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22381

View Options

applets/kicker/package/contents/ui/ItemListDialog.qml

Loading...
View Options

containments/desktop/package/contents/ui/FolderViewDialog.qml

Loading...