TransferHistory is derived from Ui::TransferHistory, it can remove all duplicate members.
Details
Details
On first look it works, Wolfgang verify it.
Diff Detail
Diff Detail
- Repository
- R433 KGet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Wow, great!
That does indeed fix the crash, and everything seems to work as before.
See below for a mistake I spotted.
There is one problem with this though, the dialog's height is much too small now, and it doesn't remember the size either.
(worked fine before though)
| ui/history/transferhistory.cpp | ||
|---|---|---|
| 62–63 | You swapped them by mistake. | |
| 65–66 | Same here, iconView and listView are swapped, so the buttons' functionality are reversed. | |
Comment Actions
Remove unused sizeHint.
Make resize in ShowEvent or we should have a temporary widget in TransferHistory, because resize is in base constructor before setupUi call.
Comment Actions
Thank you, the size is remembered now and it uses the size stored in kgetrc.
But it still opens too small the first time, if there is no kgetrc...
Comment Actions
Maybe sizeHint is for that but it's not a big dial, no? You can always resize at your need.
Comment Actions
I thought so as well, but leaving it in doesn't seem to help either...
It would help to set a default size in the KConfigGroup::readEntry() call, but that would affect other dialogs as well.
but it's not a big dial, no? You can always resize at your need.
Sure, but ideally it shouldn't be necessary. And it's not that it's slightly too small, but you cannot even see a single row of downloads...
I would actually say "ship it", but the other "fix" doesn't have that problem.
And I feel a bit uneasy because I'd like to be sure the initial size can be fixed too (without a bigger rework).
As I said, I definitely like this, but I'd want to spend more time on it first.
Comment Actions
No from my side.
IMHO, that's a too big change at this point.
And TBH, I haven't even tried your latest change yet.
The crash is fixed by D8730 anyway, so let's better target this for 18.04...
Comment Actions
Actually I did try the latest version a bit now, and it seems to work fine AFAICT.
So feel free to push it, if you are confident about it.
I'm still not sure about 17.12.0 though (maybe better .1?), but it's your decision.