Most of the changes in this diff look unrelated. Can you use this patch to only make the change in src/views/dolphinview.cpp, and focus on modernizing the code to use nullptr in another patch?

Also, I've been told that translation fixes shouldn't be done in patches. We should be using the existing localization tools for that.

Great, will have a look in the next days if no one beats me to it.

Just some general remarks:

• You've got some unrelated changes in this Diff, i.e. some older commits slipped in. Maybe you need to rebase? In general you can check with arc which how your arc diff will turn out. Just try again with arc diff, no need to open a new Diff.
• Adding a dependent Diff is not really necessary if it is already committed. This is mainly to prevent you from landing changes with unmet deps, visualize the dep stack and help reviewers get all Diffs with a single arc patch.

Looks fine now, we all struggled with arc at first before getting comfortable :)

To add to my remark from above:

• I'd just use something like "This is a follow-up patch to Dxxx", so Phab adds links without creating a dep stack.
• Apparently if you add Fixes T7432, the task you opened will get closed on commit. I'd be interested to know if that works…

Excellent, will test tonight.

Maybe I should set up phabricator locally on my machine to figure out all its magic :)

In D8740#166130, @rkflx wrote:

Looks fine now, we all struggled with arc at first before getting comfortable :)

To add to my remark from above:

• I'd just use something like "This is a follow-up patch to Dxxx", so Phab adds links without creating a dep stack.
• Apparently if you add Fixes T7432, the task you opened will get closed on commit. I'd be interested to know if that works…

Thanks for your advice! The T7432 task was mistakenly created, so we can delete it (if that is possible)

Just as a side node, this won't be needed once we'll have D7571, but for now we do need it indeed.

In D8740#166130, @rkflx wrote:

• Apparently if you add Fixes T7432, the task you opened will get closed on commit. I'd be interested to know if that works…

Sure, that works.