Add DBus interface to OrientationSensor and a persistent configuration
ClosedPublic
Actions

Authored by graesslin on Nov 9 2017, 5:06 PM.

Details

Reviewers

sebas
davidedmundson

Group Reviewers

KWin
Plasma

Commits

R108:e0b1a5715bd7: Add DBus interface to OrientationSensor and a persistent configuration

Summary

The initial state for user enabled is now read from config. In addition
a DBus interface is provided exporting this property. This allows
KScreen to determine whether automatic screen rotation is available and
whether the user has it enabled or not.

Furthermore KScreen can change the property and this gets stored into
the configuration. Thus KScreen can offer a user interface to
enable/disable automatic screen rotation as well as enabling/disabling
the manual rotation based on the current user settings.

Test Plan

Not yet tested, coded on the system which doesn't have an
orientation sensor

Diff Detail

Repository

R108 KWin

Branch

orientation-sensor-dbus

Lint

No Linters Available

Unit

No Unit Test Coverage

graesslin created this revision.Nov 9 2017, 5:06 PM

Restricted Application added a project: KWin. · View Herald TranscriptNov 9 2017, 5:06 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin mentioned this in D8731: [x11] Add support for automatic screen rotation through XRandR.Nov 9 2017, 5:08 PM

anthonyfieroni added a subscriber: anthonyfieroni.Nov 9 2017, 6:36 PM

anthonyfieroni added inline comments.

orientation_sensor.cpp
106	m_userEnabled = m_config && m_config->group("OrientationSensor").readEntry("Enabled", true); ?

graesslin added inline comments.Nov 9 2017, 7:14 PM

orientation_sensor.cpp
106	I might want to extend the loadConfig with further options (who knows) and then it wouldn't help any more. Also I find the code easier to read if it's spread around more lines.

ping

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 5 2017, 4:34 PM

davidedmundson accepted this revision.Dec 5 2017, 4:54 PM

This revision is now accepted and ready to land.Dec 5 2017, 4:54 PM

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptDec 5 2017, 4:54 PM

Closed by commit R108:e0b1a5715bd7: Add DBus interface to OrientationSensor and a persistent configuration (authored by graesslin). · Explain WhyDec 26 2017, 9:03 PM

This revision was automatically updated to reflect the committed changes.

Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptDec 26 2017, 9:03 PM

anthonyfieroni mentioned this in D23591: [platforms/drm] Disable orientation sensor for now.Aug 31 2019, 9:09 AM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		autotests/CMakeLists.txt (6 lines)
A	M	org.kde.kwin.OrientationSensor.xml (6 lines)
M		orientation_sensor.h (18 lines)
M		orientation_sensor.cpp (27 lines)
M		screens.h (6 lines)
M		screens.cpp (8 lines)
M		tests/CMakeLists.txt (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	22128	9df1744		Nov 9 2017, 5:06 PM	★	★
Diff 2	24385	0abc5e0	R108:e0b1a5715bd7d0bea7867fda14c226ca0000dd1f	Dec 26 2017, 9:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d51f187f3495	efb0119d30fc	9df1744830a0	Martin Flöser	Add DBus interface to OrientationSensor and a persistent configuration (Show More…)	Nov 9 2017, 5:03 PM