Differential D872

Add a fake urlmanager for libotp (to make it compile)
ClosedPublic
Actions

Authored by knauss on Jan 27 2016, 5:17 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Maniphest Tasks
T1223: split objecttreeparer out of messageviewer
Commits
R94:cc3a6ed7ebfe: Add a fake urlmanager for libotp (to make it compile)

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 2122.Jan 27 2016, 5:17 PM
knauss retitled this revision from to Add a fake urlmanager for libotp (to make it compile).
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: mlaurent.
knauss added a task: T1223: split objecttreeparer out of messageviewer.
mlaurent edited edge metadata.Jan 28 2016, 5:52 AM

Seems ok

mlaurent added a comment.Jan 28 2016, 5:52 AM

Where is the CMakeLists.txt which adds it to list of file ?

knauss added a comment.Jan 28 2016, 11:21 AM
In D872#16958, @mlaurent wrote:

Where is the CMakeLists.txt which adds it to list of file ?

see D873 the the relevant lib is created, because till this patch libotp can't be build at all.

mlaurent accepted this revision.Jan 29 2016, 3:57 PM
mlaurent edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2016, 3:57 PM
Closed by commit R94:cc3a6ed7ebfe: Add a fake urlmanager for libotp (to make it compile) (authored by knauss). · Explain WhyFeb 3 2016, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2175

View Options

messageviewer/src/viewer/urlhandlermanager_otp.cpp

Loading...